Fix GitHubAPI fakes verification tests
#4727
Open
+33
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function signatures on `FakeGitHubAPIWithErrors` ought to match `GitHubAPI`.
All the tests in these modules use `disable_db` so mark it at module level rather than per class/test for clarity and brevity.
mikerkelly
force-pushed
the
mikerkelly/fix/github-fakes-verification
branch
from
75d13e9
to
18dc40a
Compare
Without this the tests in this module won't run when verification-tests.yml workflow executes with "pytest -m verification". See `pytest` docs [Specifying which tests to run](https://docs.pytest.org/en/stable/how-to/usage.html#specifying-which-tests-to-run) and [Working with custom markers](https://docs.pytest.org/en/7.1.x/example/markers.html).
These classes are never instantiated, only compared, so the `coverage` tool highlights them as not being covered by testing unless we mark them up as such.
mikerkelly
force-pushed
the
mikerkelly/fix/github-fakes-verification
branch
from
f6c550c
to
4ba08ff
Compare
mikerkelly
force-pushed
the
mikerkelly/fix/github-fakes-verification
branch
from
4ba08ff
to
e7311bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues in verification tests due to #4717.
Verification tests aren't run on branch/merge CI as the ones that hit the remote APIs are costly. I must have overlooked some issues locally (coverage) and/or introduced the error manually between locally testing and committing in #4717.